Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchInstanceMetadataの処理中にサーバーが強制終了された場合Lockが永遠に解除されない問題を修正 #191

Merged
merged 3 commits into from
Oct 26, 2023
Merged

fetchInstanceMetadataの処理中にサーバーが強制終了された場合Lockが永遠に解除されない問題を修正 #191

merged 3 commits into from
Oct 26, 2023

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Oct 24, 2023 •
edited
Loading

What

fetchInstanceMetadataのmutexを時間が経ったら自動でexpireされるようにする

Why

外部サーバー情報が更新されないとの報告 z-7719

Additional info (optional)

misskey-dev#11128 のサイドエフェクトである

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@u1-liquid u1-liquid requested a review from riku6460 October 24, 2023 12:32
@u1-liquid
Copy link
Member Author

u1-liquid commented Oct 26, 2023 •
edited
Loading

パッチ当てる前にとりあえず動くようにする

keydb-cli -n 1 EVAL 'local deleted = 0; for i, key in ipairs(redis.call("KEYS", "misskey.io:fetchInstanceMetadata:mutex:*")) do redis.call("UNLINK", key); deleted = deleted + 1; end; return deleted' 0

@u1-liquid u1-liquid changed the title サーバーが強制終了された場合fetchInstanceMetadataが永遠に解除されない問題を修正 サーバーが強制終了された場合fetchInstanceMetadataのlockが永遠に解除されない問題を修正 Oct 26, 2023
@u1-liquid u1-liquid changed the title サーバーが強制終了された場合fetchInstanceMetadataのlockが永遠に解除されない問題を修正 fetchInstanceMetadataの処理中にサーバーが強制終了された場合Lockが永遠に解除されない問題を修正 Oct 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@u1-liquid u1-liquid merged commit e109334 into MisskeyIO:io Oct 26, 2023
16 checks passed
@u1-liquid u1-liquid deleted the expire-fetchInstanceMetadata-mutex branch October 26, 2023 16:08
@u1-liquid u1-liquid mentioned this pull request Oct 27, 2023
Merged
5 tasks
@u1-liquid u1-liquid mentioned this pull request Mar 3, 2024
Closed
1 task
@tamaina tamaina mentioned this pull request Mar 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riku6460 riku6460 riku6460 approved these changes

Assignees
No one assigned
Labels
packages/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u1-liquid @riku6460